Libptr by env#781
Merged
Merged
Conversation
added 2 commits
May 31, 2026 15:59
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
Member
Author
|
@ncudlenco this PR changes how libptr is passed into julia from python, so it should now be picked up if PythonCall is inited during jl_init, which is the case when it is baked into a sysimage. Could you verify if this change is sufficient to use such a sysimage? I'm hopeful that this is an alternative to #773 that doesn't require any sysimage-specific handling. |
Contributor
|
I can confirm that this works fine as an alternative for #733. Way more elegant than my attempts 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass the libptr in juliacall from Python to Julia with an env var instead of by setting a secret variable in Main.
We do this because we can set the env var earlier, in particular, so that PythonCall sees it even if it is loaded during jl_init(), which happens when PythonCall is baked into a system image.
I think this resolves the issue in #773.